From: Wolfram Sang Date: Sun, 7 Jul 2024 08:28:47 +0000 (+0200) Subject: i2c: rcar: WARN about spurious irqs X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=3291d2327e4f1e83f290c26ab7e9d17fd8e1bb2e;p=users%2Fjedix%2Flinux-maple.git i2c: rcar: WARN about spurious irqs The FIXME is very old and probably needed because of some driver bug like insufficient initialization. It may well be that it was fixed meanwhile but we never know because the spurious irq is silently ignored. Add now a call trace when this happens so we have more information in case the issue still exists. Signed-off-by: Wolfram Sang Signed-off-by: Andi Shyti --- diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c index 828aa2ea0fe4c..efa3060764930 100644 --- a/drivers/i2c/busses/i2c-rcar.c +++ b/drivers/i2c/busses/i2c-rcar.c @@ -545,7 +545,7 @@ static void rcar_i2c_irq_send(struct rcar_i2c_priv *priv, u32 msr) u32 irqs_to_clear = MDE; /* FIXME: sometimes, unknown interrupt happened. Do nothing */ - if (!(msr & MDE)) + if (WARN(!(msr & MDE), "spurious irq")) return; if (msr & MAT)