From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 24 Mar 2022 05:52:07 +0000 (+0300)
Subject: lib/test: use after free in register_test_dev_kmod()
X-Git-Tag: v5.10.110~152
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=327f07e3704c821ce33e54ef5046bdf69975cb86;p=users%2Fdwmw2%2Flinux.git

lib/test: use after free in register_test_dev_kmod()

[ Upstream commit dc0ce6cc4b133f5f2beb8b47dacae13a7d283c2c ]

The "test_dev" pointer is freed but then returned to the caller.

Fixes: d9c6a72d6fa2 ("kmod: add test driver to stress test the module loader")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/lib/test_kmod.c b/lib/test_kmod.c
index eab52770070d6..c637f6b5053a9 100644
--- a/lib/test_kmod.c
+++ b/lib/test_kmod.c
@@ -1155,6 +1155,7 @@ static struct kmod_test_device *register_test_dev_kmod(void)
 	if (ret) {
 		pr_err("could not register misc device: %d\n", ret);
 		free_test_dev_kmod(test_dev);
+		test_dev = NULL;
 		goto out;
 	}