From: Jarek Poplawski <jarkao2@gmail.com>
Date: Fri, 15 Aug 2008 00:01:10 +0000 (-0700)
Subject: pkt_sched: Fix unlocking in tc_ctl_tfilter()
X-Git-Tag: v2.6.27-rc4~39^2~42
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=323c048836f73a11ded6f9743feda21c00465cb0;p=users%2Fwilly%2Fxarray.git

pkt_sched: Fix unlocking in tc_ctl_tfilter()

Fix a bug with spin_lock_bh() inserted instead of spin_unlock_bh() by
some recent patch.

Reported-by: Denys Fedoryshchenko <denys@visp.net.lb>
Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index d2b6f54a6261..5cafdd4c8018 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -280,7 +280,7 @@ replay:
 		if (n->nlmsg_type == RTM_DELTFILTER && t->tcm_handle == 0) {
 			spin_lock_bh(root_lock);
 			*back = tp->next;
-			spin_lock_bh(root_lock);
+			spin_unlock_bh(root_lock);
 
 			tfilter_notify(skb, n, tp, fh, RTM_DELTFILTER);
 			tcf_destroy(tp);