From: David Woodhouse <David.Woodhouse@intel.com>
Date: Wed, 26 Sep 2012 19:27:25 +0000 (+0100)
Subject: Fix fd/memory leak on error return from openconnect_open_https()
X-Git-Tag: v4.08~15
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=306a0fc7325bdaa08a66ff16d74716d5a11fb70e;p=users%2Fdwmw2%2Fopenconnect.git

Fix fd/memory leak on error return from openconnect_open_https()

Spotted by Coverity.

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
---

diff --git a/gnutls.c b/gnutls.c
index 3513ccb1..aa02e0d7 100644
--- a/gnutls.c
+++ b/gnutls.c
@@ -1843,6 +1843,9 @@ int openconnect_open_https(struct openconnect_info *vpninfo)
 		vpn_progress(vpninfo, PRG_ERR,
 			     _("Failed to set TLS priority string: %s\n"),
 			     gnutls_strerror(err));
+		gnutls_deinit(vpninfo->https_sess);
+		vpninfo->https_sess = NULL;
+		close(ssl_sock);
 		return -EIO;
 	}