From: Pei Xiao Date: Wed, 19 Feb 2025 02:42:02 +0000 (+0800) Subject: leds: st1202: Refactor st1202_led_set() to use !! operator for boolean conversion X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=2f372a5dce6885f1d2647f7add01756bee0fef49;p=linux.git leds: st1202: Refactor st1202_led_set() to use !! operator for boolean conversion st1202_led_set function now uses the !! operator to convert the enum led_brightness() value to a boolean active state, which is then passed to the st1202_channel_set() function. This change maintains the existing functionality. cocci warnings: drivers/leds/leds-st1202.c:194:66-71: WARNING: conversion to bool not needed here. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202502181845.xESVrC61-lkp@intel.com/ Signed-off-by: Pei Xiao Link: https://lore.kernel.org/r/tencent_3DF7518D407679C99C4CCCB1B8E64638700A@qq.com Signed-off-by: Lee Jones --- diff --git a/drivers/leds/leds-st1202.c b/drivers/leds/leds-st1202.c index 657c62cb24fa..360e9db78dc1 100644 --- a/drivers/leds/leds-st1202.c +++ b/drivers/leds/leds-st1202.c @@ -189,9 +189,8 @@ static int st1202_channel_set(struct st1202_chip *chip, int led_num, bool active static int st1202_led_set(struct led_classdev *ldev, enum led_brightness value) { struct st1202_led *led = cdev_to_st1202_led(ldev); - struct st1202_chip *chip = led->chip; - return st1202_channel_set(chip, led->led_num, value == LED_OFF ? false : true); + return st1202_channel_set(led->chip, led->led_num, !!value); } static int st1202_led_pattern_clear(struct led_classdev *ldev)