From: Dan Carpenter Date: Tue, 26 Apr 2022 08:49:20 +0000 (+0300) Subject: drm/amdgpu: debugfs: fix NULL dereference in ta_if_invoke_debugfs_write() X-Git-Tag: howlett/maple/20220722_2~460^2~12^2~36 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=2f33a397e9605e70fe2082d727aa1501a9386b95;p=users%2Fjedix%2Flinux-maple.git drm/amdgpu: debugfs: fix NULL dereference in ta_if_invoke_debugfs_write() If the kzalloc() fails then this code will crash. Return -ENOMEM instead. Fixes: e50d9ba0d2cd ("drm/amdgpu: Add debugfs TA load/unload/invoke support") Signed-off-by: Dan Carpenter Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c index 32bcc20b9e3f..6806deb098d3 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp_ta.c @@ -254,7 +254,7 @@ static ssize_t ta_if_invoke_debugfs_write(struct file *fp, const char *buf, size shared_buf = kzalloc(shared_buf_len, GFP_KERNEL); if (!shared_buf) - ret = -ENOMEM; + return -ENOMEM; if (copy_from_user((void *)shared_buf, &buf[copy_pos], shared_buf_len)) { ret = -EFAULT; goto err_free_shared_buf;