From: YueHaibing <yuehaibing@huawei.com>
Date: Tue, 18 Dec 2018 01:34:39 +0000 (+0000)
Subject: cifs: Use GFP_ATOMIC when a lock is held in cifs_mount()
X-Git-Tag: v5.0-rc1~62^2~8
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=2f0a617448945a2c63d68983212302e9f2f8ae2f;p=users%2Fdwmw2%2Flinux.git

cifs: Use GFP_ATOMIC when a lock is held in cifs_mount()

A spin lock is held before kstrndup, it may sleep with holding
the spinlock, so we should use GFP_ATOMIC instead.

Fixes: e58c31d5e387 ("cifs: Add support for failover in cifs_reconnect()")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Paulo Alcantara <palcantara@suse.de>
---

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index ef51cf748db72..8de2173efdc5f 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -4585,7 +4585,8 @@ int cifs_mount(struct cifs_sb_info *cifs_sb, struct smb_vol *vol)
 		tcon->remap = cifs_remap(cifs_sb);
 	}
 	cifs_sb->origin_fullpath = kstrndup(tcon->dfs_path,
-					    strlen(tcon->dfs_path), GFP_KERNEL);
+					    strlen(tcon->dfs_path),
+					    GFP_ATOMIC);
 	if (!cifs_sb->origin_fullpath) {
 		spin_unlock(&cifs_tcp_ses_lock);
 		rc = -ENOMEM;