From: Mike Christie <mchristi@redhat.com>
Date: Thu, 2 Mar 2017 05:14:40 +0000 (-0600)
Subject: tcmu: return on first Opt parse failure
X-Git-Tag: v4.1.12-105.0.20170622_2100~11
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=2de21e4431856e4411338e2f8f93087781b13c5e;p=users%2Fjedix%2Flinux-maple.git

tcmu: return on first Opt parse failure

We only were returing failure if the last opt to be parsed failed.
This has a return failure when we first detect a failure.

Signed-off-by: Mike Christie <mchristi@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

Orabug: 25395066
(cherry picked from commit 2579325ca0acc598fdf41ba12b2871d3467f28df)
Signed-off-by: Kyle Fortin <kyle.fortin@oracle.com>
Reviewed-by: Shan Hai <shan.hai@oracle.com>
---

diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
index 1f6f86667d57..26b8fc38300f 100644
--- a/drivers/target/target_core_user.c
+++ b/drivers/target/target_core_user.c
@@ -1111,6 +1111,9 @@ static ssize_t tcmu_set_configfs_dev_params(struct se_device *dev,
 		default:
 			break;
 		}
+
+		if (ret)
+			break;
 	}
 
 	kfree(orig);