From: Peng Fan Date: Tue, 7 Jul 2020 08:50:42 +0000 (+0800) Subject: spi: atmel: No need to call spi_master_put() if spi_alloc_master() failed X-Git-Tag: howlett/maple_spf/20210104~1195^2~61 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=2d9a744685bc3a4bf1d097782550c450ff0c3b04;p=users%2Fjedix%2Flinux-maple.git spi: atmel: No need to call spi_master_put() if spi_alloc_master() failed There is no need to call spi_master_put() if spi_alloc_master() failed, it should return -ENOMEM directly. Signed-off-by: Peng Fan Link: https://lore.kernel.org/r/1594111842-9468-1-git-send-email-fanpeng@loongson.cn Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c index 57ee8c3b7972..6ed7abdcf74a 100644 --- a/drivers/spi/spi-atmel.c +++ b/drivers/spi/spi-atmel.c @@ -1546,10 +1546,9 @@ static int atmel_spi_probe(struct platform_device *pdev) return PTR_ERR(clk); /* setup spi core then atmel-specific driver state */ - ret = -ENOMEM; master = spi_alloc_master(&pdev->dev, sizeof(*as)); if (!master) - goto out_free; + return -ENOMEM; /* the spi->mode bits understood by this driver: */ master->use_gpio_descriptors = true;