From: Todd Vierling Date: Tue, 28 Jun 2016 19:56:13 +0000 (-0400) Subject: RDS: IB: change rds_ib_active_bonding_excl_ips to only RFC3927 space X-Git-Tag: v4.1.12-92~118^2~1 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=2c51dcf6cec7613b324afaf69d9558ca6629f509;p=users%2Fjedix%2Flinux-maple.git RDS: IB: change rds_ib_active_bonding_excl_ips to only RFC3927 space Currently rds_ib_active_bonding_excl_ips excludes both 169.254.0.0/16 and 172.10.0.0/16 address ranges from use with RDS bonding. This parameter was meant to default to the range used by link-local addresses (169.254.0.0/16, RFC3927) as those do not play nicely with InfiniBand. "172.10/16" was probably a mistaken typing of "172.16/12", which is one of the private use -- but not link-local -- ranges defined by RFC1918. 172.10.0.0/16 is in active use on the global Internet (part of the block 172.0.0.0/12 as of this writing); it doesn't belong here. Change the parameter default to only "169.254/16" per the original change's intent. Orabug; 23712042 Signed-off-by: Todd Vierling Signed-off-by: Santosh Shilimkar --- diff --git a/net/rds/ib.c b/net/rds/ib.c index 63a2ac02b01b..dbc711214f92 100644 --- a/net/rds/ib.c +++ b/net/rds/ib.c @@ -61,7 +61,7 @@ unsigned int rds_ib_active_bonding_trigger_delay_min_msecs; /* = 0; */ unsigned int rds_ib_rnr_retry_count = RDS_IB_DEFAULT_RNR_RETRY_COUNT; static char *rds_ib_active_bonding_failover_groups = NULL; unsigned int rds_ib_active_bonding_arps = RDS_IB_DEFAULT_NUM_ARPS; -static char *rds_ib_active_bonding_excl_ips = "169.254/16,172.10/16"; +static char *rds_ib_active_bonding_excl_ips = "169.254/16"; module_param(rds_ib_fmr_1m_pool_size, int, 0444); MODULE_PARM_DESC(rds_ib_fmr_1m_pool_size, " Max number of 1m fmr per HCA");