From: Martin George <marting@netapp.com>
Date: Mon, 15 Apr 2024 06:58:43 +0000 (+0530)
Subject: tree: fix mem leak in nvme_ns_init()
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=2b4b321d9a371dba527b59fbf0f91e77e92e1665;p=users%2Fsagi%2Flibnvme.git

tree: fix mem leak in nvme_ns_init()

Valgrind revealed a mem leak in nvme_ns_init() invoked by
several nvme commands such as connect-all, list, disconnect-all,
etc. Leak traced to the nvme_ns_id pointer not getting freed
after use. Fix the same.

Signed-off-by: Martin George <marting@netapp.com>
---

diff --git a/src/nvme/tree.c b/src/nvme/tree.c
index 59387bf8..2218d5a8 100644
--- a/src/nvme/tree.c
+++ b/src/nvme/tree.c
@@ -2488,7 +2488,7 @@ static int nvme_ns_init(const char *path, struct nvme_ns *ns)
 		if (ret)
 			return ret;
 	} else {
-		struct nvme_id_ns *id;
+		_cleanup_free_ struct nvme_id_ns *id = NULL;
 		uint8_t flbas;
 
 		id = __nvme_alloc(sizeof(*ns));