From: Trond Myklebust <trond.myklebust@hammerspace.com>
Date: Sat, 11 Apr 2020 15:37:18 +0000 (-0400)
Subject: pNFS: Fix RCU lock leakage
X-Git-Tag: v5.7-rc1~9^2
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=27d231c0c63bb619997a24bab85d54d90ca71110;p=users%2Fdwmw2%2Flinux.git

pNFS: Fix RCU lock leakage

Another brown paper bag moment. pnfs_alloc_ds_commits_list() is leaking
the RCU lock.

Fixes: a9901899b649 ("pNFS: Add infrastructure for cleaning up per-layout commit structures")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
---

diff --git a/fs/nfs/pnfs_nfs.c b/fs/nfs/pnfs_nfs.c
index 25f135572fc8b..e7ddbce48321d 100644
--- a/fs/nfs/pnfs_nfs.c
+++ b/fs/nfs/pnfs_nfs.c
@@ -501,6 +501,7 @@ pnfs_alloc_ds_commits_list(struct list_head *list,
 		rcu_read_lock();
 		pnfs_put_commit_array(array, cinfo->inode);
 	}
+	rcu_read_unlock();
 	return ret;
 }