From: Enric Balletbo i Serra Date: Mon, 13 Apr 2020 14:10:51 +0000 (+0200) Subject: power: supply: bq24257_charger: Replace depends on REGMAP_I2C with select X-Git-Tag: v5.7.6~473 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=27bc8ad4802919d89c5c7ce5e67d6f110165047a;p=users%2Fdwmw2%2Flinux.git power: supply: bq24257_charger: Replace depends on REGMAP_I2C with select [ Upstream commit 87c3d579c8ed0eaea6b1567d529a8daa85a2bc6c ] regmap is a library function that gets selected by drivers that need it. No driver modules should depend on it. Depending on REGMAP_I2C makes this driver only build if another driver already selected REGMAP_I2C, as the symbol can't be selected through the menu kernel configuration. Fixes: 2219a935963e ("power_supply: Add TI BQ24257 charger driver") Signed-off-by: Enric Balletbo i Serra Signed-off-by: Sebastian Reichel Signed-off-by: Sasha Levin --- diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig index f3424fdce341a..d37ec0d03237f 100644 --- a/drivers/power/supply/Kconfig +++ b/drivers/power/supply/Kconfig @@ -577,7 +577,7 @@ config CHARGER_BQ24257 tristate "TI BQ24250/24251/24257 battery charger driver" depends on I2C depends on GPIOLIB || COMPILE_TEST - depends on REGMAP_I2C + select REGMAP_I2C help Say Y to enable support for the TI BQ24250, BQ24251, and BQ24257 battery chargers.