From: Tom Herbert <tom@herbertland.com>
Date: Thu, 20 Aug 2015 00:07:34 +0000 (-0700)
Subject: fou: Do WARN_ON_ONCE in gue_gro_receive for bad proto callbacks
X-Git-Tag: v4.1.12-111.0.20170918_2215~168
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=23683e8f0beea777e3ed606520185cda124af2e5;p=users%2Fjedix%2Flinux-maple.git

fou: Do WARN_ON_ONCE in gue_gro_receive for bad proto callbacks

Do WARN_ON_ONCE instead of WARN_ON in gue_gro_receive when the offload
callcaks are bad (either don't exist or gro_receive is not specified).

Signed-off-by: Tom Herbert <tom@herbertland.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

Orabug: 25879842
(cherry picked from commit 270136613bf7306e2b83457628e2b2f6c6be3989)
Signed-off-by: Cathy Zhou <Cathy.Zhou@Oracle.COM>
Reviewed-by: Jack Vogel <jack.vogel@oracle.com>
---

diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c
index 909ca7001fa9a..6a4245b2aac29 100644
--- a/net/ipv4/fou.c
+++ b/net/ipv4/fou.c
@@ -348,7 +348,7 @@ static struct sk_buff **gue_gro_receive(struct sk_buff **head,
 	rcu_read_lock();
 	offloads = NAPI_GRO_CB(skb)->is_ipv6 ? inet6_offloads : inet_offloads;
 	ops = rcu_dereference(offloads[guehdr->proto_ctype]);
-	if (WARN_ON(!ops || !ops->callbacks.gro_receive))
+	if (WARN_ON_ONCE(!ops || !ops->callbacks.gro_receive))
 		goto out_unlock;
 
 	pp = call_gro_receive(ops->callbacks.gro_receive, head, skb);