From: Ido Schimmel <idosch@nvidia.com>
Date: Wed, 26 Aug 2020 16:48:53 +0000 (+0300)
Subject: ipv4: nexthop: Remove unnecessary rtnl_dereference()
X-Git-Tag: howlett/maple_spf/20210104~792^2~431^2~4
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=233c63785cd92e12d61b283d0eaeafc867fc45f5;p=users%2Fjedix%2Flinux-maple.git

ipv4: nexthop: Remove unnecessary rtnl_dereference()

The pointer is not RCU protected, so remove the unnecessary
rtnl_dereference(). This suppresses the following warning:

net/ipv4/nexthop.c:1101:24: error: incompatible types in comparison expression (different address spaces):
net/ipv4/nexthop.c:1101:24:    struct rb_node [noderef] __rcu *
net/ipv4/nexthop.c:1101:24:    struct rb_node *

Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/ipv4/nexthop.c b/net/ipv4/nexthop.c
index 0823643a7dec..1b736e3e1baa 100644
--- a/net/ipv4/nexthop.c
+++ b/net/ipv4/nexthop.c
@@ -1098,7 +1098,7 @@ static int insert_nexthop(struct net *net, struct nexthop *new_nh,
 	while (1) {
 		struct nexthop *nh;
 
-		next = rtnl_dereference(*pp);
+		next = *pp;
 		if (!next)
 			break;