From: Anthony Romano <anthony.romano@coreos.com>
Date: Fri, 24 Jun 2016 21:48:43 +0000 (-0700)
Subject: tmpfs: don't undo fallocate past its last page
X-Git-Tag: v4.1.12-92~15^2~107
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=22b13cba5db39833c80f4f2b41b94ae7b4a169d0;p=users%2Fjedix%2Flinux-maple.git

tmpfs: don't undo fallocate past its last page

Orabug: 25308028

[ Upstream commit b9b4bb26af017dbe930cd4df7f9b2fc3a0497bfe ]

When fallocate is interrupted it will undo a range that extends one byte
past its range of allocated pages.  This can corrupt an in-use page by
zeroing out its first byte.  Instead, undo using the inclusive byte
range.

Fixes: 1635f6a74152f1d ("tmpfs: undo fallocation on failure")
Link: http://lkml.kernel.org/r/1462713387-16724-1-git-send-email-anthony.romano@coreos.com
Signed-off-by: Anthony Romano <anthony.romano@coreos.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Hugh Dickins <hughd@google.com>
Cc: Brandon Philips <brandon@ifup.co>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
(cherry picked from commit c5bcec6cbcbf520f088dc7939934bbf10c20c5a5)
Signed-off-by: Dhaval Giani <dhaval.giani@oracle.com>
---

diff --git a/mm/shmem.c b/mm/shmem.c
index 47d536e59fc02..86c150bf82353 100644
--- a/mm/shmem.c
+++ b/mm/shmem.c
@@ -2139,7 +2139,7 @@ static long shmem_fallocate(struct file *file, int mode, loff_t offset,
 			/* Remove the !PageUptodate pages we added */
 			shmem_undo_range(inode,
 				(loff_t)start << PAGE_CACHE_SHIFT,
-				(loff_t)index << PAGE_CACHE_SHIFT, true);
+				((loff_t)index << PAGE_CACHE_SHIFT) - 1, true);
 			goto undone;
 		}