From: Maurizio Lombardi <mlombard@redhat.com>
Date: Fri, 6 Dec 2024 13:17:06 +0000 (+0100)
Subject: ns_descs: prevent buffer overrun and memory corruption
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=22948efa3977c9c96aa3ccf6e7e7d341d48971bf;p=users%2Fsagi%2Fnvme-cli.git

ns_descs: prevent buffer overrun and memory corruption

nsdescs should point to an allocated memory of size
NVME_IDENTIFY_DATA_SIZE bytes, not "sizeof(*void)" bytes.

Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
---

diff --git a/nvme.c b/nvme.c
index 4db3cd63..16acaf9f 100644
--- a/nvme.c
+++ b/nvme.c
@@ -3700,7 +3700,7 @@ static int ns_descs(int argc, char **argv, struct command *cmd, struct plugin *p
 		}
 	}
 
-	nsdescs = nvme_alloc(sizeof(*nsdescs));
+	nsdescs = nvme_alloc(NVME_IDENTIFY_DATA_SIZE);
 	if (!nsdescs)
 		return -ENOMEM;