From: Tang Bin Date: Thu, 19 Mar 2020 14:03:47 +0000 (+0800) Subject: mailbox:armada-37xx-rwtm:remove duplicate print in armada_37xx_mbox_probe() X-Git-Tag: v5.7-rc1~137^2~10 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=223a83bdcc56effed63661ac9ae209fea0223078;p=users%2Fjedix%2Flinux-maple.git mailbox:armada-37xx-rwtm:remove duplicate print in armada_37xx_mbox_probe() In this function,we don't need dev_err() message because when something goes wrong,platform_get_irq() and devm_platform_ioremap_resource() have print an error message itself, so we should remove duplicate dev_err(). Signed-off-by: Tang Bin Signed-off-by: Jassi Brar --- diff --git a/drivers/mailbox/armada-37xx-rwtm-mailbox.c b/drivers/mailbox/armada-37xx-rwtm-mailbox.c index 02b7b28e6969..9f2ce7f03c67 100644 --- a/drivers/mailbox/armada-37xx-rwtm-mailbox.c +++ b/drivers/mailbox/armada-37xx-rwtm-mailbox.c @@ -156,16 +156,12 @@ static int armada_37xx_mbox_probe(struct platform_device *pdev) return -ENOMEM; mbox->base = devm_platform_ioremap_resource(pdev, 0); - if (IS_ERR(mbox->base)) { - dev_err(&pdev->dev, "ioremap failed\n"); + if (IS_ERR(mbox->base)) return PTR_ERR(mbox->base); - } mbox->irq = platform_get_irq(pdev, 0); - if (mbox->irq < 0) { - dev_err(&pdev->dev, "Cannot get irq\n"); + if (mbox->irq < 0) return mbox->irq; - } mbox->dev = &pdev->dev;