From: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Date: Thu, 21 Feb 2019 04:42:45 +0000 (-0800)
Subject: nvme/025: use consistent coding style
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=21027950a81beb3780d0be50fdaa19a3c0f6e23d;p=users%2Fsagi%2Fblktests.git

nvme/025: use consistent coding style

Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---

diff --git a/tests/nvme/025 b/tests/nvme/025
index 741d374..6468f59 100755
--- a/tests/nvme/025
+++ b/tests/nvme/025
@@ -38,11 +38,11 @@ test() {
 	cat "/sys/block/${nvmedev}n1/uuid"
 	cat "/sys/block/${nvmedev}n1/wwid"
 
-	nvme effects-log "/dev/${nvmedev}" > /dev/null 2>&1
-
-	rc=$?
+	if ! nvme effects-log "/dev/${nvmedev}" >> "$FULL" 2>&1; then
+		echo "ERROR: effects-log failed"
+	fi
 
-	nvme disconnect -n "${subsys_name}"
+	nvme disconnect -n "${subsys_name}" >> "$FULL" 2>&1
 
 	_remove_nvmet_subsystem_from_port "${port}" "${subsys_name}"
 	_remove_nvmet_subsystem "${subsys_name}"
@@ -53,9 +53,5 @@ test() {
 	modprobe -r nvme-loop
 	modprobe -r nvmet
 
-	if [ $rc -ne 0 ]; then
-		echo "Test Failed"
-	else
-		echo "Test complete"
-	fi
+	echo "Test complete"
 }
diff --git a/tests/nvme/025.out b/tests/nvme/025.out
index b700bc7..f15ff2f 100644
--- a/tests/nvme/025.out
+++ b/tests/nvme/025.out
@@ -1,5 +1,4 @@
 Running nvme/025
 91fdba0d-f87b-4c25-b80f-db7be1418b9e
 uuid.91fdba0d-f87b-4c25-b80f-db7be1418b9e
-NQN:blktests-subsystem-1 disconnected 1 controller(s)
 Test complete