From: Colin Ian King Date: Thu, 21 May 2020 13:50:38 +0000 (+0100) Subject: staging: fbtft: fb_st7789v: make HSD20_IPS numeric and not a string X-Git-Tag: v5.8-rc1~106^2~51 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=20edb44179e94c918eb9d5bfbe98d395d3cbe4d7;p=linux.git staging: fbtft: fb_st7789v: make HSD20_IPS numeric and not a string Currently HSD20_IPS is defined as "true" and will always result in a non-zero result even if it is defined as "false" because it is an array and that will never be zero. Fix this by defining it as an integer 1 rather than a literal string. Addessses-Coverity: ("Array compared against 0") Fixes: f03c9b788472 ("staging: fbtft: fb_st7789v: Initialize the Display") Signed-off-by: Colin Ian King Link: https://lore.kernel.org/r/20200521135038.345878-1-colin.king@canonical.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/fbtft/fb_st7789v.c b/drivers/staging/fbtft/fb_st7789v.c index ebc17e05ecd0..3a280cc1892c 100644 --- a/drivers/staging/fbtft/fb_st7789v.c +++ b/drivers/staging/fbtft/fb_st7789v.c @@ -24,7 +24,7 @@ "D0 05 0A 09 08 05 2E 44 45 0F 17 16 2B 33\n" \ "D0 05 0A 09 08 05 2E 43 45 0F 16 16 2B 33" -#define HSD20_IPS "true" +#define HSD20_IPS 1 /** * enum st7789v_command - ST7789V display controller commands