From: Shin'ichiro Kawasaki Date: Thu, 31 Aug 2023 06:25:45 +0000 (+0900) Subject: block/002,scsi/007,zbd/003: remove options for shellcheck SC2119 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=2045e8d3df86d75b6fc89fc21d7cc9211959561e;p=users%2Fsagi%2Fblktests.git block/002,scsi/007,zbd/003: remove options for shellcheck SC2119 The commits 852996fea4f1 and 45b203cce8ba added options of a few function calls to avoid the shellcheck warning SC2119. After that, SC2119 was disabled with the commit 3d1c0fe2677d. Then the added options are no longer needed. Remove them to clean up. Link: https://lore.kernel.org/linux-nvme/o5xnqvujzakhrudv7p64owiuzgozmean6blxow4vdxhdqozg5v@qznf2tzmey7k/ Signed-off-by: Shin'ichiro Kawasaki --- diff --git a/tests/block/002 b/tests/block/002 index b16d014..ee8b0bc 100755 --- a/tests/block/002 +++ b/tests/block/002 @@ -19,7 +19,7 @@ requires() { test() { echo "Running ${TEST_NAME}" - if ! _configure_scsi_debug delay=0; then + if ! _configure_scsi_debug; then return 1 fi diff --git a/tests/scsi/007 b/tests/scsi/007 index 547a735..fa8a3fc 100755 --- a/tests/scsi/007 +++ b/tests/scsi/007 @@ -28,7 +28,7 @@ test() { echo "Running ${TEST_NAME}" - if ! _init_scsi_debug delay=0; then + if ! _init_scsi_debug; then return 1 fi diff --git a/tests/zbd/003 b/tests/zbd/003 index 44dba17..7f4fa2c 100755 --- a/tests/zbd/003 +++ b/tests/zbd/003 @@ -43,7 +43,7 @@ test_device() { # Select 2 target zones so that reset zone range also get tested _get_blkzone_report "${TEST_DEV}" || return $? - zone_idx=$(_find_two_contiguous_seq_zones "") || return $? + zone_idx=$(_find_two_contiguous_seq_zones) || return $? target_zones=( "${zone_idx}" "$((zone_idx + 1))" ) # Reset the 2 target zones and write 4KB in each zone to increment