From: Satendra Singh Thakur Date: Sat, 9 Nov 2019 11:35:23 +0000 (+0530) Subject: dmaengine: mediatek: hsdma_probe: fixed a memory leak when devm_request_irq fails X-Git-Tag: v5.5-rc1~78^2~12 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=1ff95243257fad07290dcbc5f7a6ad79d6e703e2;p=linux.git dmaengine: mediatek: hsdma_probe: fixed a memory leak when devm_request_irq fails When devm_request_irq fails, currently, the function dma_async_device_unregister gets called. This doesn't free the resources allocated by of_dma_controller_register. Therefore, we have called of_dma_controller_free for this purpose. Signed-off-by: Satendra Singh Thakur Link: https://lore.kernel.org/r/20191109113523.6067-1-sst2005@gmail.com Signed-off-by: Vinod Koul --- diff --git a/drivers/dma/mediatek/mtk-hsdma.c b/drivers/dma/mediatek/mtk-hsdma.c index 1a2028e1c29e9..4c58da7421432 100644 --- a/drivers/dma/mediatek/mtk-hsdma.c +++ b/drivers/dma/mediatek/mtk-hsdma.c @@ -997,7 +997,7 @@ static int mtk_hsdma_probe(struct platform_device *pdev) if (err) { dev_err(&pdev->dev, "request_irq failed with err %d\n", err); - goto err_unregister; + goto err_free; } platform_set_drvdata(pdev, hsdma); @@ -1006,6 +1006,8 @@ static int mtk_hsdma_probe(struct platform_device *pdev) return 0; +err_free: + of_dma_controller_free(pdev->dev.of_node); err_unregister: dma_async_device_unregister(dd);