From: Maurizio Lombardi <mlombard@redhat.com>
Date: Tue, 8 Nov 2022 09:54:32 +0000 (+0100)
Subject: mi: fix a static checker warning in examples/mi-mctp
X-Git-Tag: v1.3~36
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=1fb997321c339806248d6111802e4a743ce68079;p=users%2Fsagi%2Flibnvme.git

mi: fix a static checker warning in examples/mi-mctp

tmp is an "unsigned long" variable so it can't be less than zero.

Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
---

diff --git a/examples/mi-mctp.c b/examples/mi-mctp.c
index 8d660afb..c9a38523 100644
--- a/examples/mi-mctp.c
+++ b/examples/mi-mctp.c
@@ -347,14 +347,14 @@ int do_admin_raw(nvme_mi_ep_t ep, int argc, char **argv)
 	}
 
 	tmp = atoi(argv[1]);
-	if (tmp < 0 || tmp > 0xffff) {
+	if (tmp > 0xffff) {
 		fprintf(stderr, "invalid controller ID\n");
 		return -1;
 	}
 	ctrl_id = tmp & 0xffff;
 
 	tmp = atoi(argv[2]);
-	if (tmp < 0 || tmp > 0xff) {
+	if (tmp > 0xff) {
 		fprintf(stderr, "invalid opcode\n");
 		return -1;
 	}
@@ -461,7 +461,7 @@ int do_security_info(nvme_mi_ep_t ep, int argc, char **argv)
 	}
 
 	tmp = atoi(argv[1]);
-	if (tmp < 0 || tmp > 0xffff) {
+	if (tmp > 0xffff) {
 		fprintf(stderr, "invalid controller ID\n");
 		return -1;
 	}