From: Johan Hovold <johan@kernel.org>
Date: Tue, 6 Jun 2017 15:58:58 +0000 (+0200)
Subject: USB: core: fix device node leak
X-Git-Tag: v4.12.1~20
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=1e35d149befae9ef34f50782cade48a64cc9d64f;p=users%2Fdwmw2%2Flinux.git

USB: core: fix device node leak

commit e271b2c909a22a2c13b2d5f77f2ce0091b74540c upstream.

Make sure to release any OF device-node reference taken when creating
the USB device.

Note that we currently do not hold a reference to the root hub
device-tree node (i.e. the parent controller node).

Fixes: 69bec7259853 ("USB: core: let USB device know device node")
Acked-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c
index 28b053cacc905..62e1906bb2f31 100644
--- a/drivers/usb/core/usb.c
+++ b/drivers/usb/core/usb.c
@@ -416,6 +416,8 @@ static void usb_release_dev(struct device *dev)
 
 	usb_destroy_configuration(udev);
 	usb_release_bos_descriptor(udev);
+	if (udev->parent)
+		of_node_put(dev->of_node);
 	usb_put_hcd(hcd);
 	kfree(udev->product);
 	kfree(udev->manufacturer);