From: Christoph Hellwig <hch@lst.de>
Date: Thu, 16 Sep 2021 07:04:00 +0000 (+0200)
Subject: m68k: Document that access_ok is broken for !CONFIG_CPU_HAS_ADDRESS_SPACES
X-Git-Tag: xarray-5.18~920^2~5
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=1dc4027bc8b524ed03c4db391cd7910eb4ee19d2;p=users%2Fwilly%2Fxarray.git

m68k: Document that access_ok is broken for !CONFIG_CPU_HAS_ADDRESS_SPACES

Document that access_ok is completely broken for coldfire and friends at
the moment.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Michael Schmitz <schmitzmic@gmail.com>
Tested-by: Michael Schmitz <schmitzmic@gmail.com>
Link: https://lore.kernel.org/r/20210916070405.52750-2-hch@lst.de
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---

diff --git a/arch/m68k/include/asm/uaccess.h b/arch/m68k/include/asm/uaccess.h
index f98208ccbbcd..610bfe8d64d5 100644
--- a/arch/m68k/include/asm/uaccess.h
+++ b/arch/m68k/include/asm/uaccess.h
@@ -16,6 +16,10 @@
 static inline int access_ok(const void __user *addr,
 			    unsigned long size)
 {
+	/*
+	 * XXX: for !CONFIG_CPU_HAS_ADDRESS_SPACES this really needs to check
+	 * for TASK_SIZE!
+	 */
 	return 1;
 }