From: Trond Myklebust Date: Fri, 18 Jul 2025 23:15:27 +0000 (-0700) Subject: NFS: Fix wakeup of __nfs_lookup_revalidate() in unblock_revalidate() X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=1db3a48e83bb64a70bf27263b7002585574a9c2d;p=users%2Fjedix%2Flinux-maple.git NFS: Fix wakeup of __nfs_lookup_revalidate() in unblock_revalidate() Use store_release_wake_up() to add the appropriate memory barrier before calling wake_up_var(&dentry->d_fsdata). Reported-by: Lukáš Hejtmánek Suggested-by: Santosh Pradhan Link: https://lore.kernel.org/all/18945D18-3EDB-4771-B019-0335CE671077@ics.muni.cz/ Fixes: 99bc9f2eb3f7 ("NFS: add barriers when testing for NFS_FSDATA_BLOCKED") Signed-off-by: Trond Myklebust --- diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index d0e0b435a8431..d812179239362 100644 --- a/fs/nfs/dir.c +++ b/fs/nfs/dir.c @@ -1828,9 +1828,7 @@ static void block_revalidate(struct dentry *dentry) static void unblock_revalidate(struct dentry *dentry) { - /* store_release ensures wait_var_event() sees the update */ - smp_store_release(&dentry->d_fsdata, NULL); - wake_up_var(&dentry->d_fsdata); + store_release_wake_up(&dentry->d_fsdata, NULL); } /*