From: Colin Ian King Date: Mon, 2 Nov 2020 12:16:15 +0000 (+0000) Subject: net: dev_ioctl: remove redundant initialization of variable err X-Git-Tag: xarray-5.12~769^2~343 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=1ca47431c29c63ffc521e17bdc97be5472599776;p=users%2Fwilly%2Fxarray.git net: dev_ioctl: remove redundant initialization of variable err The variable err is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King Link: https://lore.kernel.org/r/20201102121615.695196-1-colin.king@canonical.com Signed-off-by: Jakub Kicinski --- diff --git a/net/core/dev_ioctl.c b/net/core/dev_ioctl.c index 205e92e604ef..db8a0ff86f36 100644 --- a/net/core/dev_ioctl.c +++ b/net/core/dev_ioctl.c @@ -230,7 +230,7 @@ static int dev_do_ioctl(struct net_device *dev, struct ifreq *ifr, unsigned int cmd) { const struct net_device_ops *ops = dev->netdev_ops; - int err = -EOPNOTSUPP; + int err; err = dsa_ndo_do_ioctl(dev, ifr, cmd); if (err == 0 || err != -EOPNOTSUPP)