From: Guenter Roeck <linux@roeck-us.net>
Date: Sat, 4 Jul 2015 20:23:42 +0000 (-0700)
Subject: hwmon: (nct7802) Fix integer overflow seen when writing voltage limits
X-Git-Tag: v4.1.5~23
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=1c57a6c95d3de1ea32010d88b9b93984d3302e8d;p=users%2Fjedix%2Flinux-maple.git

hwmon: (nct7802) Fix integer overflow seen when writing voltage limits

commit 9200bc4c28cd8992eb5379345abd6b4f0c93df16 upstream.

Writing a large value into a voltage limit attribute can result
in an overflow due to an auto-conversion from unsigned long to
unsigned int.

Cc: Constantine Shulyupin <const@MakeLinux.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/hwmon/nct7802.c b/drivers/hwmon/nct7802.c
index 28fcb2e246d55..fbfc02bb2cfa1 100644
--- a/drivers/hwmon/nct7802.c
+++ b/drivers/hwmon/nct7802.c
@@ -195,7 +195,7 @@ abort:
 }
 
 static int nct7802_write_voltage(struct nct7802_data *data, int nr, int index,
-				 unsigned int voltage)
+				 unsigned long voltage)
 {
 	int shift = 8 - REG_VOLTAGE_LIMIT_MSB_SHIFT[index - 1][nr];
 	int err;