From: Venkat Jayaraman Date: Fri, 5 Sep 2025 18:44:01 +0000 (-0700) Subject: usb: typec: ucsi: Add check for UCSI version X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=1bc28f015a19a10b7a305fc561c1143c34a1e04a;p=users%2Fhch%2Fmisc.git usb: typec: ucsi: Add check for UCSI version "Power Reading" bit is introduced in UCSI v2.1 and so limit the check for that bit only if version supported is 2.1 or above. Fixes: c851b71fd6cd ("usb: typec: ucsi: Add support for READ_POWER_LEVEL command") Signed-off-by: Venkat Jayaraman Reviewed-by: Heikki Krogerus Link: https://lore.kernel.org/r/20250905184401.3222530-1-venkat.jayaraman@intel.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c index 0d6b0cf5a7cd..3f568f790f39 100644 --- a/drivers/usb/typec/ucsi/ucsi.c +++ b/drivers/usb/typec/ucsi/ucsi.c @@ -1293,7 +1293,8 @@ static void ucsi_handle_connector_change(struct work_struct *work) if (change & UCSI_CONSTAT_BC_CHANGE) ucsi_port_psy_changed(con); - if (UCSI_CONSTAT(con, PWR_READING_READY_V2_1)) { + if (con->ucsi->version >= UCSI_VERSION_2_1 && + UCSI_CONSTAT(con, PWR_READING_READY_V2_1)) { curr_scale = UCSI_CONSTAT(con, CURRENT_SCALE_V2_1); volt_scale = UCSI_CONSTAT(con, VOLTAGE_SCALE_V2_1);