From: Ding Xiang <dingxiang@cmss.chinamobile.com>
Date: Wed, 15 Jun 2022 09:36:29 +0000 (+0800)
Subject: tools/testing/selftests/vm/ksm_tests.c: fix resource leak when return error
X-Git-Tag: maple_v12_fixes~87
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=1b40d99542436644f9c36811785bf9d10d911f7d;p=users%2Fjedix%2Flinux-maple.git

tools/testing/selftests/vm/ksm_tests.c: fix resource leak when return error

When return on an error path, file handle need to be closed to prevent
resource leak

Link: https://lkml.kernel.org/r/20220615093629.1330809-1-dingxiang@cmss.chinamobile.com
Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

diff --git a/tools/testing/selftests/vm/ksm_tests.c b/tools/testing/selftests/vm/ksm_tests.c
index 2fcf24312da8..f5e4e0bbd081 100644
--- a/tools/testing/selftests/vm/ksm_tests.c
+++ b/tools/testing/selftests/vm/ksm_tests.c
@@ -54,6 +54,7 @@ static int ksm_write_sysfs(const char *file_path, unsigned long val)
 	}
 	if (fprintf(f, "%lu", val) < 0) {
 		perror("fprintf");
+		fclose(f);
 		return 1;
 	}
 	fclose(f);
@@ -72,6 +73,7 @@ static int ksm_read_sysfs(const char *file_path, unsigned long *val)
 	}
 	if (fscanf(f, "%lu", val) != 1) {
 		perror("fscanf");
+		fclose(f);
 		return 1;
 	}
 	fclose(f);