From: Bartosz Golaszewski Date: Tue, 10 Jun 2025 15:20:36 +0000 (+0200) Subject: staging: greybus: remove unnecessary GPIO line direction check X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=1b30f644f7e2b8d4352b7a796496c41f81aa72ed;p=users%2Fjedix%2Flinux-maple.git staging: greybus: remove unnecessary GPIO line direction check As of commit 92ac7de3175e3 ("gpiolib: don't allow setting values on input lines"), the GPIO core makes sure values cannot be set on input lines. Remove the unnecessary check. Signed-off-by: Bartosz Golaszewski Reviewed-by: Rui Miguel Silva Link: https://lore.kernel.org/r/20250610152036.86099-1-brgl@bgdev.pl Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c index f81c34160f720..1280530c8987a 100644 --- a/drivers/staging/greybus/gpio.c +++ b/drivers/staging/greybus/gpio.c @@ -192,12 +192,6 @@ static int gb_gpio_set_value_operation(struct gb_gpio_controller *ggc, struct gb_gpio_set_value_request request; int ret; - if (ggc->lines[which].direction == 1) { - dev_warn(dev, "refusing to set value of input gpio %u\n", - which); - return -EPERM; - } - request.which = which; request.value = value_high ? 1 : 0; ret = gb_operation_sync(ggc->connection, GB_GPIO_TYPE_SET_VALUE,