From: Tedd Ho-Jeong An Date: Wed, 26 May 2021 17:36:22 +0000 (-0700) Subject: Bluetooth: mgmt: Fix the command returns garbage parameter value X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=1920c2b5feddb62e113e9a33954cab60cfcb9352;p=users%2Fjedix%2Flinux-maple.git Bluetooth: mgmt: Fix the command returns garbage parameter value When the Get Device Flags command fails, it returns the error status with the parameters filled with the garbage values. Although the parameters are not used, it is better to fill with zero than the random values. Signed-off-by: Tedd Ho-Jeong An Signed-off-by: Marcel Holtmann --- diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c index b44e19c69c445..91d36c3bf23ee 100644 --- a/net/bluetooth/mgmt.c +++ b/net/bluetooth/mgmt.c @@ -4061,6 +4061,8 @@ static int get_device_flags(struct sock *sk, struct hci_dev *hdev, void *data, hci_dev_lock(hdev); + memset(&rp, 0, sizeof(rp)); + if (cp->addr.type == BDADDR_BREDR) { br_params = hci_bdaddr_list_lookup_with_flags(&hdev->whitelist, &cp->addr.bdaddr,