From: Olaf Hering Date: Tue, 15 Dec 2015 00:01:42 +0000 (-0800) Subject: Drivers: hv: vss: run only on supported host versions X-Git-Tag: v4.1.12-124.31.3~1221 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=18f98d3c2ed37dc758a2686418303359c3ee0071;p=users%2Fjedix%2Flinux-maple.git Drivers: hv: vss: run only on supported host versions The Backup integration service on WS2012 has appearently trouble to negotiate with a guest which does not support the provided util version. Currently the VSS driver supports only version 5/0. A WS2012 offers only version 1/x and 3/x, and vmbus_prep_negotiate_resp correctly returns an empty icframe_vercnt/icmsg_vercnt. But the host ignores that and continues to send ICMSGTYPE_NEGOTIATE messages. The result are weird errors during boot and general misbehaviour. Check the Windows version to work around the host bug, skip hv_vss_init on WS2012 and older. Signed-off-by: Olaf Hering Signed-off-by: K. Y. Srinivasan Signed-off-by: Greg Kroah-Hartman Orabug: 27426063 (cherry picked from commit ed9ba608e4851144af8c7061cbb19f751c73e998) Signed-off-by: Jack Vogel Reviewed-by: Ashok Vairavan --- diff --git a/drivers/hv/hv_snapshot.c b/drivers/hv/hv_snapshot.c index 5efb7a2350f9..3fba14e88f03 100644 --- a/drivers/hv/hv_snapshot.c +++ b/drivers/hv/hv_snapshot.c @@ -330,6 +330,11 @@ static void vss_on_reset(void) int hv_vss_init(struct hv_util_service *srv) { + if (vmbus_proto_version < VERSION_WIN8_1) { + pr_warn("Integration service 'Backup (volume snapshot)'" + " not supported on this host version.\n"); + return -ENOTSUPP; + } recv_buffer = srv->recv_buffer; vss_transaction.recv_channel = srv->channel;