From: Nishka Dasgupta Date: Tue, 9 Jul 2019 17:20:30 +0000 (+0530) Subject: mtd: rawnand: ingenic: Add of_node_put() before return X-Git-Tag: v5.4-rc1~87^2~13^2~12 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=1670e678a8a72e8b09774e21986d1d77d4610f96;p=linux.git mtd: rawnand: ingenic: Add of_node_put() before return Each iteration of for_each_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the return. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta Signed-off-by: Miquel Raynal --- diff --git a/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c b/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c index d7b7c0f13909..df214e7ddec8 100644 --- a/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c +++ b/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c @@ -418,6 +418,7 @@ static int ingenic_nand_init_chips(struct ingenic_nfc *nfc, ret = ingenic_nand_init_chip(pdev, nfc, np, i); if (ret) { ingenic_nand_cleanup_chips(nfc); + of_node_put(np); return ret; }