From: bob picco Date: Fri, 10 Mar 2017 19:31:19 +0000 (-0500) Subject: sparc64: kern_addr_valid regression X-Git-Tag: v4.1.12-98.0.20170517_2143~32 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=146f5c15f549112b12fad3854092a1e82e86bb83;p=users%2Fjedix%2Flinux-maple.git sparc64: kern_addr_valid regression Orabug: 25860542 I encountered this bug when using /proc/kcore to examine the kernel. Plus a coworker inquired about debugging tools. We computed pa but did not use it during the maximum physical address bits test. Instead we used the identity mapped virtual address which will always fail this test. I believe the defect came in here: [bpicco@zareason linus.git]$ git describe --contains bb4e6e85daa52 v3.18-rc1~87^2~4 . Signed-off-by: Bob Picco Signed-off-by: David S. Miller Signed-off-by: Allen Pais --- diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c index 4c1eabe86fb4b..329eed4f10af4 100644 --- a/arch/sparc/mm/init_64.c +++ b/arch/sparc/mm/init_64.c @@ -1825,7 +1825,7 @@ bool kern_addr_valid(unsigned long addr) if ((long)addr < 0L) { unsigned long pa = __pa(addr); - if ((addr >> max_phys_bits) != 0UL) + if ((pa >> max_phys_bits) != 0UL) return false; return pfn_valid(pa >> PAGE_SHIFT);