From: Lukas Czerner <lczerner@redhat.com>
Date: Wed, 3 Oct 2018 01:18:45 +0000 (-0400)
Subject: ext4: initialize retries variable in ext4_da_write_inline_data_begin()
X-Git-Tag: v4.14.81~87
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=13b63ba40348d9c43c3842632d3f371a97ca5fe4;p=users%2Fjedix%2Flinux-maple.git

ext4: initialize retries variable in ext4_da_write_inline_data_begin()

commit 625ef8a3acd111d5f496d190baf99d1a815bd03e upstream.

Variable retries is not initialized in ext4_da_write_inline_data_begin()
which can lead to nondeterministic number of retries in case we hit
ENOSPC. Initialize retries to zero as we do everywhere else.

Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Fixes: bc0ca9df3b2a ("ext4: retry allocation when inline->extent conversion failed")
Cc: stable@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
index 4e1d62ba0703f..ac2e0516c16ff 100644
--- a/fs/ext4/inline.c
+++ b/fs/ext4/inline.c
@@ -869,7 +869,7 @@ int ext4_da_write_inline_data_begin(struct address_space *mapping,
 	handle_t *handle;
 	struct page *page;
 	struct ext4_iloc iloc;
-	int retries;
+	int retries = 0;
 
 	ret = ext4_get_inode_loc(inode, &iloc);
 	if (ret)