From: Stephen Boyd <sboyd@kernel.org>
Date: Wed, 26 Feb 2025 23:54:07 +0000 (-0800)
Subject: clk: Print an error when clk registration fails
X-Git-Tag: v6.15-rc1~103^2~2^4~4
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=12a0fd23e87000e69b1777a9765c0c6e6eed0cd9;p=linux.git

clk: Print an error when clk registration fails

We have a lot of driver code that prints an error message when
registering a clk fails. Do that in the core function instead to
consolidate code. This also helps drivers avoid the anti-pattern of
accessing the struct clk_hw::init pointer after registration.

Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Link: https://lore.kernel.org/r/20250226235408.1339266-1-sboyd@kernel.org
---

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 00c1a89a852a..3938f2600209 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -4397,6 +4397,13 @@ fail_ops:
 fail_name:
 	kref_put(&core->ref, __clk_release);
 fail_out:
+	if (dev) {
+		dev_err_probe(dev, ret, "failed to register clk '%s' (%pS)\n",
+			      init->name, hw);
+	} else {
+		pr_err("%pOF: error %pe: failed to register clk '%s' (%pS)\n",
+		       np, ERR_PTR(ret), init->name, hw);
+	}
 	return ERR_PTR(ret);
 }