From: Suraj Kandpal Date: Tue, 19 Aug 2025 16:04:39 +0000 (+0530) Subject: drm/i915/backlight: Fix divide by 0 error in i9xx_set_backlight X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=11c09b55b3d36f5cfa15873e2e0f1e04166bcfd4;p=users%2Fhch%2Fmisc.git drm/i915/backlight: Fix divide by 0 error in i9xx_set_backlight pwm_level_max maybe 0 we do throw a warning but move ahead with execution which may later cause a /0 error. --v2 -return if the warn_on gets hit [Jani] Signed-off-by: Suraj Kandpal Reviewed-by: Jani Nikula Link: https://lore.kernel.org/r/20250819160438.145734-1-suraj.kandpal@intel.com --- diff --git a/drivers/gpu/drm/i915/display/intel_backlight.c b/drivers/gpu/drm/i915/display/intel_backlight.c index e007380e9a63..3b14f929825a 100644 --- a/drivers/gpu/drm/i915/display/intel_backlight.c +++ b/drivers/gpu/drm/i915/display/intel_backlight.c @@ -236,7 +236,8 @@ static void i9xx_set_backlight(const struct drm_connector_state *conn_state, u32 struct intel_panel *panel = &connector->panel; u32 tmp, mask; - drm_WARN_ON(display->drm, panel->backlight.pwm_level_max == 0); + if (drm_WARN_ON(display->drm, panel->backlight.pwm_level_max == 0)) + return; if (panel->backlight.combination_mode) { struct pci_dev *pdev = to_pci_dev(display->drm->dev);