From: Hannes Reinecke <hare@suse.de>
Date: Thu, 16 Nov 2023 06:15:06 +0000 (+0100)
Subject: libnvme: separate out 'gen_tls_identity' and reshuffle 'derive_nvme_keys'
X-Git-Tag: v1.7~22^2~3
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=10517fb7efaadc265ed4f1296fb9453252f51fe6;p=users%2Fsagi%2Flibnvme.git

libnvme: separate out 'gen_tls_identity' and reshuffle 'derive_nvme_keys'

Separate out a function to generate the TLS identity; this allows
us to reshuffle 'derive_nvme_keys()' to compile it only when
KEYUTILS is selected.

Signed-off-by: Hannes Reinecke <hare@suse.de>
---

diff --git a/src/nvme/linux.c b/src/nvme/linux.c
index e620f4c3..ec63e52d 100644
--- a/src/nvme/linux.c
+++ b/src/nvme/linux.c
@@ -542,11 +542,33 @@ int nvme_gen_dhchap_key(char *hostnqn, enum nvme_hmac_alg hmac,
 	return 0;
 }
 
-static int derive_nvme_keys(const char *hostnqn, const char *identity,
-			    int hmac, unsigned char *configured,
-			    unsigned char *psk, int key_len)
+static int derive_retained_key(int hmac, const char *hostnqn,
+			       unsigned char *generated,
+			       unsigned char *retained,
+			       size_t key_len)
+{
+	nvme_msg(NULL, LOG_ERR, "NVMe TLS is not supported; "
+		 "recompile with OpenSSL support.\n");
+	errno = NOTSUP;
+	return -1;
+}
+
+static int gen_tls_identity(const char *hostnqn, const char *subsysnqn,
+			    int hmac, char *identity,
+			    unsigned char *retained, size_t key_len)
 {
-	errno = EOPNOTSUPP;
+	sprintf(identity, "NVMe0R%02d %s %s",
+		version, hmac, hostnqn, subsysnqn);
+	return strlen(identity);
+}
+
+static int derive_tls_key(int hmac, const char *identity,
+			  unsigned char *retained,
+			  unsigned char *psk, size_t key_len)
+{
+	nvme_msg(NULL, LOG_ERR, "NVMe TLS is not supported; "
+		 "recompile with OpenSSL support.\n");
+	errno = NOTSUP;
 	return -1;
 }
 #else /* CONFIG_OPENSSL */
@@ -683,30 +705,6 @@ out_free_ctx:
 
 	return ret;
 }
-
-static int derive_nvme_keys(const char *hostnqn, const char *identity,
-			    int hmac, unsigned char *configured,
-			    unsigned char *psk, int key_len)
-{
-	unsigned char *retained;
-	int ret = -1;
-
-	if (!hostnqn || !identity) {
-		errno = EINVAL;
-		return -1;
-	}
-
-	retained = malloc(key_len);
-	if (!retained) {
-		errno = ENOMEM;
-		return -1;
-	}
-	ret = derive_retained_key(hmac, hostnqn, configured, retained, key_len);
-	if (ret > 0)
-		ret = derive_tls_key(hmac, identity, retained, psk, key_len);
-	free(retained);
-	return ret;
-}
 #endif /* CONFIG_OPENSSL */
 
 #ifdef CONFIG_OPENSSL_1
@@ -780,6 +778,15 @@ out:
 	HMAC_CTX_free(hmac_ctx);
 	return err;
 }
+
+static int gen_tls_identity(const char *hostnqn, const char *subsysnqn,
+			    int hmac, char *identity,
+			    unsigned char *retained, size_t key_len)
+{
+	sprintf(identity, "NVMe0R%02d %s %s",
+		hmac, hostnqn, subsysnqn);
+	return strlen(identity);
+}
 #endif /* !CONFIG_OPENSSL_1 */
 
 #ifdef CONFIG_OPENSSL_3
@@ -874,9 +881,49 @@ out:
 
 	return err;
 }
+
+static int gen_tls_identity(const char *hostnqn, const char *subsysnqn,
+			    int hmac, char *identity,
+			    unsigned char *retained, size_t key_len)
+{
+	sprintf(identity, "NVMe0R%02d %s %s",
+		version, hmac, hostnqn, subsysnqn);
+	return strlen(identity);
+}
 #endif /* !CONFIG_OPENSSL_3 */
 
 #ifdef CONFIG_KEYUTILS
+static int derive_nvme_keys(const char *hostnqn, const char *subsysnqn,
+			    char *identity,
+			    int hmac, unsigned char *configured,
+			    unsigned char *psk, int key_len)
+{
+	unsigned char *retained;
+	int ret = -1;
+
+	if (!hostnqn || !subsysnqn || !identity) {
+		errno = EINVAL;
+		return -1;
+	}
+
+	retained = malloc(key_len);
+	if (!retained) {
+		errno = ENOMEM;
+		return -1;
+	}
+	ret = derive_retained_key(hmac, hostnqn, configured, retained, key_len);
+	if (ret < 0)
+		goto out;
+	ret = gen_tls_identity(hostnqn, subsysnqn, hmac,
+			       identity, retained, key_len);
+	if (ret < 0)
+		goto out;
+	ret = derive_tls_key(hmac, identity, retained, psk, key_len);
+out:
+	free(retained);
+	return ret;
+}
+
 long nvme_lookup_keyring(const char *keyring)
 {
 	key_serial_t keyring_id;
@@ -922,6 +969,7 @@ long nvme_insert_tls_key(const char *keyring, const char *key_type,
 {
 	key_serial_t keyring_id, key = 0;
 	char *identity;
+	size_t identity_len;
 	unsigned char *psk;
 	int ret = -1;
 
@@ -929,21 +977,20 @@ long nvme_insert_tls_key(const char *keyring, const char *key_type,
 	if (keyring_id == 0)
 		return -1;
 
-	identity = malloc(strlen(hostnqn) + strlen(subsysnqn) + 12);
+	identity_len = strlen(hostnqn) + strlen(subsysnqn) + 12;
+	identity = malloc(identity_len);
 	if (!identity) {
 		errno = ENOMEM;
 		return -1;
 	}
 
-	sprintf(identity, "NVMe0R%02d %s %s", hmac, hostnqn, subsysnqn);
-
 	psk = malloc(key_len);
 	if (!psk) {
 		errno = ENOMEM;
 		goto out_free_identity;
 	}
 	memset(psk, 0, key_len);
-	ret = derive_nvme_keys(hostnqn, identity, hmac,
+	ret = derive_nvme_keys(hostnqn, subsysnqn, identity, hmac,
 			       configured_key, psk, key_len);
 	if (ret != key_len)
 		goto out_free_psk;
@@ -1002,6 +1049,9 @@ long nvme_insert_tls_key(const char *keyring, const char *key_type,
 			 const char *hostnqn, const char *subsysnqn, int hmac,
 			 unsigned char *configured_key, int key_len)
 {
-	return derive_nvme_keys(NULL, NULL, 0, NULL, NULL, 0);
+	nvme_msg(NULL, LOG_ERR, "key operations not supported; "
+		 "recompile with keyutils support.\n");
+	errno = ENOTSUP;
+	return -1;
 }
 #endif