From: Dennis Maisenbacher <dennis.maisenbacher@wdc.com>
Date: Fri, 8 Nov 2024 09:29:17 +0000 (+0000)
Subject: tests: Fix `subprosess.call` calls
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=1024886e0ddce829f7243d2f61e7b0e77513b137;p=users%2Fsagi%2Fnvme-cli.git

tests: Fix `subprosess.call` calls

Don't use stdout=PIPE with subprocess.call as noted in the documentation:
https://docs.python.org/3/library/subprocess.html#subprocess.call

Signed-off-by: Dennis Maisenbacher <dennis.maisenbacher@wdc.com>
---

diff --git a/tests/nvme_test.py b/tests/nvme_test.py
index 923e6747..863fc023 100644
--- a/tests/nvme_test.py
+++ b/tests/nvme_test.py
@@ -167,8 +167,7 @@ class TestNVMe(unittest.TestCase):
         nvme_reset_cmd = f"{self.nvme_bin} reset {self.ctrl}"
         err = subprocess.call(nvme_reset_cmd,
                               shell=True,
-                              stdout=subprocess.PIPE,
-                              encoding='utf-8')
+                              stdout=subprocess.DEVNULL)
         self.assertEqual(err, 0, "ERROR : nvme reset failed")
         rescan_cmd = "echo 1 > /sys/bus/pci/rescan"
         proc = subprocess.Popen(rescan_cmd,
@@ -392,8 +391,7 @@ class TestNVMe(unittest.TestCase):
                 f"--namespace-id={str(nsid)}"
             err = subprocess.call(id_ns_cmd,
                                   shell=True,
-                                  stdout=subprocess.PIPE,
-                                  encoding='utf-8')
+                                  stdout=subprocess.DEVNULL)
         return err
 
     def attach_ns(self, ctrl_id, ns_id):
@@ -408,8 +406,7 @@ class TestNVMe(unittest.TestCase):
             f"--namespace-id={str(ns_id)} --controllers={ctrl_id}"
         err = subprocess.call(attach_ns_cmd,
                               shell=True,
-                              stdout=subprocess.PIPE,
-                              encoding='utf-8')
+                              stdout=subprocess.DEVNULL)
         if err == 0:
             # enumerate new namespace block device
             self.nvme_reset_ctrl()
@@ -429,8 +426,7 @@ class TestNVMe(unittest.TestCase):
             f"--namespace-id={str(nsid)} --controllers={ctrl_id}"
         return subprocess.call(detach_ns_cmd,
                                shell=True,
-                               stdout=subprocess.PIPE,
-                               encoding='utf-8')
+                               stdout=subprocess.DEVNULL)
 
     def delete_and_validate_ns(self, nsid):
         """ Wrapper for deleting and validating that namespace is deleted.
@@ -444,8 +440,7 @@ class TestNVMe(unittest.TestCase):
             f"--namespace-id={str(nsid)}"
         err = subprocess.call(delete_ns_cmd,
                               shell=True,
-                              stdout=subprocess.PIPE,
-                              encoding='utf-8')
+                              stdout=subprocess.DEVNULL)
         self.assertEqual(err, 0, "ERROR : delete namespace failed")
         return err