From: Ivan Vecera Date: Thu, 15 Oct 2015 19:28:52 +0000 (+0200) Subject: drivers/net: get rid of unnecessary initializations in .get_drvinfo() X-Git-Tag: v4.1.12-92~189^2~429 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=0dacc526954a70d7fb6d50a8705a4b2115d59da0;p=users%2Fjedix%2Flinux-maple.git drivers/net: get rid of unnecessary initializations in .get_drvinfo() Many drivers initialize uselessly n_priv_flags, n_stats, testinfo_len, eedump_len & regdump_len fields in their .get_drvinfo() ethtool op. It's not necessary as these fields is filled in ethtool_get_drvinfo(). v2: removed unused variable v3: removed another unused variable Signed-off-by: Ivan Vecera Signed-off-by: David S. Miller Signed-off-by: Suresh Reddy Signed-off-by: Suresh Reddy Orabug: 22725582 Signed-off-by: Manjunath Govindashetty --- diff --git a/drivers/net/ethernet/emulex/benet/be_ethtool.c b/drivers/net/ethernet/emulex/benet/be_ethtool.c index 2c9ed1710ba6f..f4cb8e425853a 100644 --- a/drivers/net/ethernet/emulex/benet/be_ethtool.c +++ b/drivers/net/ethernet/emulex/benet/be_ethtool.c @@ -234,9 +234,6 @@ static void be_get_drvinfo(struct net_device *netdev, strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), sizeof(drvinfo->bus_info)); - drvinfo->testinfo_len = 0; - drvinfo->regdump_len = 0; - drvinfo->eedump_len = 0; } static u32 lancer_cmd_get_file_len(struct be_adapter *adapter, u8 *file_name)