From: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: Tue, 24 Sep 2024 11:43:56 +0000 (+0400)
Subject: linux-user/hppa: fix -Werror=maybe-uninitialized false-positive
X-Git-Tag: pull-vmclock-20250108~130^2~7
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=0d0f95c7bcde008510e6c9013e00b25941c83871;p=users%2Fdwmw2%2Fqemu.git

linux-user/hppa: fix -Werror=maybe-uninitialized false-positive

../linux-user/hppa/cpu_loop.c: In function ‘hppa_lws’:
../linux-user/hppa/cpu_loop.c:106:17: error: ‘ret’ may be used uninitialized [-Werror=maybe-uninitialized]
  106 |     env->gr[28] = ret;

Add g_assert_not_reached() to help compiler, as suggested by Laurent.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
---

diff --git a/linux-user/hppa/cpu_loop.c b/linux-user/hppa/cpu_loop.c
index bc093b8fe8..23b38ff9b2 100644
--- a/linux-user/hppa/cpu_loop.c
+++ b/linux-user/hppa/cpu_loop.c
@@ -99,6 +99,8 @@ static abi_ulong hppa_lws(CPUHPPAState *env)
 #endif
             }
             break;
+        default:
+            g_assert_not_reached();
         }
         break;
     }