From: Al Viro <viro@zeniv.linux.org.uk>
Date: Tue, 26 Mar 2019 01:40:38 +0000 (+0000)
Subject: ubifs: fix use-after-free on symlink traversal
X-Git-Tag: v5.1-rc4~30^2~1
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=0cdc17ebd2072b6cdd3ec3695ea7ede745664a8b;p=users%2Fjedix%2Flinux-maple.git

ubifs: fix use-after-free on symlink traversal

free the symlink body after the same RCU delay we have for freeing the
struct inode itself, so that traversal during RCU pathwalk wouldn't step
into freed memory.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---

diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index 8dc2818fdd84..12628184772c 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -276,14 +276,12 @@ static void ubifs_i_callback(struct rcu_head *head)
 {
 	struct inode *inode = container_of(head, struct inode, i_rcu);
 	struct ubifs_inode *ui = ubifs_inode(inode);
+	kfree(ui->data);
 	kmem_cache_free(ubifs_inode_slab, ui);
 }
 
 static void ubifs_destroy_inode(struct inode *inode)
 {
-	struct ubifs_inode *ui = ubifs_inode(inode);
-
-	kfree(ui->data);
 	call_rcu(&inode->i_rcu, ubifs_i_callback);
 }