From: Jeff Layton <jlayton@redhat.com>
Date: Fri, 27 Apr 2018 16:34:59 +0000 (-0400)
Subject: src/fsync-err: don't truncate files on second open
X-Git-Tag: v2022.05.01~1586
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=0c2896508f44a61431d0dee9257154adc3c42561;p=users%2Fhch%2Fxfstests-dev.git

src/fsync-err: don't truncate files on second open

...and no need for O_CREAT flag.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Eryu Guan <guaneryu@gmail.com>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
---

diff --git a/src/fsync-err.c b/src/fsync-err.c
index 146688ddb..bd05dcc0a 100644
--- a/src/fsync-err.c
+++ b/src/fsync-err.c
@@ -170,9 +170,9 @@ int main(int argc, char **argv)
 			ret = fsync(fd[i]);
 			if (ret < 0) {
 				/*
-				 * We did a failed write and fsync on each fd before.
-				 * Now the error should be clear since we've not done
-				 * any writes since then.
+				 * We did a failed write and fsync on each fd
+				 * before.  Now the error should be clear since
+				 * we've not done any writes since then.
 				 */
 				printf("Third fsync on fd[%d] failed: %m\n", i);
 				return 1;
@@ -220,7 +220,7 @@ int main(int argc, char **argv)
 			printf("Close of fd[%d] returned unexpected error: %m\n", i);
 			return 1;
 		}
-		fd[i] = open(fname, O_WRONLY | O_CREAT | O_TRUNC, 0644);
+		fd[i] = open(fname, O_WRONLY, 0644);
 		if (fd[i] < 0) {
 			printf("Second open of fd[%d] failed: %m\n", i);
 			return 1;