From: Dimitri Papadopoulos <3350651+DimitriPapadopoulos@users.noreply.gitlab.com>
Date: Wed, 16 Jun 2021 12:01:50 +0000 (+0200)
Subject: Fix bad function definition
X-Git-Tag: v8.20~118^2~1
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=0bef505c6f0eaa4edce6a95a312b840959802a1f;p=users%2Fdwmw2%2Fopenconnect.git

Fix bad function definition

Warnings by checkpatch.pl.
I have learned something today:
https://eklitzke.org/c-functions-without-arguments

Signed-off-by: Dimitri Papadopoulos <3350651+DimitriPapadopoulos@users.noreply.gitlab.com>
---

diff --git a/array.c b/array.c
index 1aba7bda..01eeb80e 100644
--- a/array.c
+++ b/array.c
@@ -48,7 +48,7 @@
 
 #include "openconnect-internal.h"
 
-static struct oc_auth_form *plain_auth_form() {
+static struct oc_auth_form *plain_auth_form(void) {
         struct oc_auth_form *form;
         struct oc_form_opt *opt, *opt2, *opt3;
 
diff --git a/compat.c b/compat.c
index f83a520b..c0d1a4dc 100644
--- a/compat.c
+++ b/compat.c
@@ -268,7 +268,7 @@ char *openconnect__win32_strerror(DWORD err)
 	return msgutf8;
 }
 
-int openconnect__win32_sock_init()
+int openconnect__win32_sock_init(void)
 {
 	WSADATA data;
 	if (WSAStartup (MAKEWORD(1, 1), &data) != 0) {
diff --git a/f5.c b/f5.c
index df26d2f8..99eb4ee2 100644
--- a/f5.c
+++ b/f5.c
@@ -37,7 +37,7 @@
 
 #define XCAST(x) ((const xmlChar *)(x))
 
-static struct oc_auth_form *plain_auth_form() {
+static struct oc_auth_form *plain_auth_form(void) {
 	struct oc_auth_form *form;
 	struct oc_form_opt *opt, *opt2;
 
diff --git a/gnutls.c b/gnutls.c
index 4cabc6dd..b8a55e92 100644
--- a/gnutls.c
+++ b/gnutls.c
@@ -67,7 +67,7 @@ static int gnutls_pin_callback(void *priv, int attempt, const char *uri,
 
 static char tls_library_version[32] = "";
 
-const char *openconnect_get_tls_library_version()
+const char *openconnect_get_tls_library_version(void)
 {
 	if (!*tls_library_version) {
 		snprintf(tls_library_version, sizeof(tls_library_version), "GnuTLS %s",
@@ -76,7 +76,7 @@ const char *openconnect_get_tls_library_version()
 	return tls_library_version;
 }
 
-int can_enable_insecure_crypto()
+int can_enable_insecure_crypto(void)
 {
 	/* XX: As of GnuTLS 3.6.13, no released version has (yet) removed 3DES/RC4 from default builds,
 	 * but like OpenSSL (removed in 1.1.0) it may happen. */
diff --git a/openssl.c b/openssl.c
index 1a1c134f..c33908e9 100644
--- a/openssl.c
+++ b/openssl.c
@@ -52,7 +52,7 @@ typedef int (*X509_STORE_CTX_get_issuer_fn)(X509 **issuer,
 
 static char tls_library_version[32] = "";
 
-const char *openconnect_get_tls_library_version()
+const char *openconnect_get_tls_library_version(void)
 {
 	if (!*tls_library_version) {
 		strncpy(tls_library_version, SSLeay_version(SSLEAY_VERSION), sizeof(tls_library_version));
@@ -61,7 +61,7 @@ const char *openconnect_get_tls_library_version()
 	return tls_library_version;
 }
 
-int can_enable_insecure_crypto()
+int can_enable_insecure_crypto(void)
 {
 	if (EVP_des_ede3_cbc() == NULL ||
 	    EVP_rc4() == NULL)
diff --git a/ssl.c b/ssl.c
index d5b33da4..1f60d5c0 100644
--- a/ssl.c
+++ b/ssl.c
@@ -65,7 +65,7 @@
 #endif
 #endif
 
-static inline int connect_pending()
+static inline int connect_pending(void)
 {
 #ifdef _WIN32
 	return WSAGetLastError() == WSAEWOULDBLOCK;