From: Eric Sandeen <sandeen@redhat.com>
Date: Tue, 18 Feb 2014 10:18:20 +0000 (+1100)
Subject: xfs: ensure bad primary sb crc fails mount
X-Git-Tag: v2022.05.01~3242
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=0ab3beb126116cd8a3093d8391092d8c2ce59500;p=users%2Fhch%2Fxfstests-dev.git

xfs: ensure bad primary sb crc fails mount

the commit:
10e6e65 xfs: be more forgiving of a v4 secondary sb w/ junk in v5 fields
broke primary sb CRC validation, not erroring out the mount
if the crc was bad.

This tests that it's fixed, and properly fails the mount on
a bad crc.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
---

diff --git a/tests/xfs/005 b/tests/xfs/005
new file mode 100755
index 000000000..94157c4c3
--- /dev/null
+++ b/tests/xfs/005
@@ -0,0 +1,66 @@
+#! /bin/bash
+# FS QA Test No. 005
+#
+# Test that a bad crc on a primary V5 superblock will fail the mount
+#
+# 10e6e65 xfs: be more forgiving of a v4 secondary sb w/ junk in v5 fields
+# inadvertently caused primary SB CRC failures to not error out, this
+# is a regression test for that fix.
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2014 Red Hat, Inc.  All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#-----------------------------------------------------------------------
+#
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1	# failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+    cd /
+    rm -f $tmp.*
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+# Modify as appropriate.
+_supported_fs xfs
+_supported_os Linux
+
+_require_scratch
+_require_xfs_mkfs_crc
+
+rm -f $seqres.full
+
+_scratch_mkfs_xfs -m crc=1 >> $seqres.full 2>&1 || _fail "mkfs failed"
+
+# Zap the crc.  xfs_db updates the CRC post-write, so poke it directly
+$XFS_IO_PROG -c "pwrite 224 4" $SCRATCH_DEV | _filter_xfs_io
+
+# should FAIL, the crc is bad; golden output contains mount failure
+_scratch_mount
+
+# success, all done
+status=0
+exit
diff --git a/tests/xfs/005.out b/tests/xfs/005.out
new file mode 100644
index 000000000..13d0125a5
--- /dev/null
+++ b/tests/xfs/005.out
@@ -0,0 +1,4 @@
+QA output created by 005
+wrote 4/4 bytes at offset 224
+XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
+mount: Structure needs cleaning
diff --git a/tests/xfs/group b/tests/xfs/group
index d3b8afd3c..ba34650a9 100644
--- a/tests/xfs/group
+++ b/tests/xfs/group
@@ -2,6 +2,7 @@
 002 auto quick growfs
 003 db auto quick
 004 db auto quick
+005 auto quick
 008 rw ioctl auto quick
 009 rw ioctl auto prealloc quick
 012 rw auto quick