From: Daniel Wagner <dwagner@suse.de>
Date: Wed, 15 Feb 2023 11:28:01 +0000 (+0100)
Subject: nvme: Use fprintf for error message logging in get_log()
X-Git-Tag: v2.4~62
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=09e749ff62a1c108feb6799f0e8515d2a8eb938a;p=users%2Fsagi%2Fnvme-cli.git

nvme: Use fprintf for error message logging in get_log()

perror uses the errno variable which is likely set to 0, which leads to
error messages like

  non-zero log-len is required param: Success

Use fprintf and write to stderr the error messages.

Signed-off-by: Daniel Wagner <dwagner@suse.de>
---

diff --git a/nvme.c b/nvme.c
index e10e3823..b76df852 100644
--- a/nvme.c
+++ b/nvme.c
@@ -2179,19 +2179,19 @@ static int get_log(int argc, char **argv, struct command *cmd, struct plugin *pl
 	}
 
 	if (!cfg.log_len) {
-		perror("non-zero log-len is required param\n");
+		fprintf(stderr, "non-zero log-len is required param\n");
 		err = -EINVAL;
 		goto close_dev;
 	}
 
 	if (cfg.lsp > 128) {
-		perror("invalid lsp param\n");
+		fprintf(stderr, "invalid lsp param\n");
 		err = -EINVAL;
 		goto close_dev;
 	}
 
 	if (cfg.uuid_index > 128) {
-		perror("invalid uuid index param\n");
+		fprintf(stderr, "invalid uuid index param\n");
 		err = -EINVAL;
 		goto close_dev;
 	}