From: Martin Wilck <mwilck@suse.com>
Date: Tue, 23 May 2023 12:19:14 +0000 (+0200)
Subject: fabrics: add udev rule to avoid renaming nbft interfaces
X-Git-Tag: v2.7~95
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=096c3e6677c5cb28e445c6630bc8b49ae9dc5704;p=users%2Fsagi%2Fnvme-cli.git

fabrics: add udev rule to avoid renaming nbft interfaces

In the initramfs, the interface naming is taken care of by dracut.
But there are various network-interface-naming policies in place which
may attempt to rename the interface, causing confusion and possibly
wrong interface parameters.

Add an udev rule that avoids renaming any network interface that
has been assigned a name nbft$N, which is by convention the naming
scheme that is used for NBFT device in the initramfs.

Note: The simpler 'NAME:="%k"' directive doesn't work because udev rejects
it ('Ignoring NAME="%k", as it will take no effect.'). The ":=" syntax makes
sure the interface isn't renamed any more by later rules. "INTERFACE" is set
by the kernel in the "add" uevent for a network interface.

Signed-off-by: Martin Wilck <mwilck@suse.com>
---

diff --git a/meson.build b/meson.build
index d837aa9c..864ed0d4 100644
--- a/meson.build
+++ b/meson.build
@@ -236,6 +236,7 @@ foreach file : systemd_files
 endforeach
 
 udev_files = [
+  '65-persistent-net-nbft.rules',
   '70-nvmf-autoconnect.rules',
   '71-nvmf-netapp.rules',
 ]
diff --git a/nvmf-autoconnect/udev-rules/65-persistent-net-nbft.rules.in b/nvmf-autoconnect/udev-rules/65-persistent-net-nbft.rules.in
new file mode 100644
index 00000000..344942bc
--- /dev/null
+++ b/nvmf-autoconnect/udev-rules/65-persistent-net-nbft.rules.in
@@ -0,0 +1,2 @@
+# Avoid renaming nbft$X interfaces
+SUBSYSTEM=="net", ACTION!="remove", ENV{INTERFACE}=="nbft*", NAME:="%E{INTERFACE}"