From: Rosen Penev <rosenp@gmail.com>
Date: Mon, 7 Oct 2024 23:57:11 +0000 (-0700)
Subject: net: ibm: emac: mal: fix wrong goto
X-Git-Tag: dma-mapping-6.12-2024-10-20~33^2~20
X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=08c8acc9d8f3f70d62dd928571368d5018206490;p=users%2Fhch%2Fdma-mapping.git

net: ibm: emac: mal: fix wrong goto

dcr_map is called in the previous if and therefore needs to be unmapped.

Fixes: 1ff0fcfcb1a6 ("ibm_newemac: Fix new MAL feature handling")
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Link: https://patch.msgid.link/20241007235711.5714-1-rosenp@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---

diff --git a/drivers/net/ethernet/ibm/emac/mal.c b/drivers/net/ethernet/ibm/emac/mal.c
index d92dd9c83031..0c5e22d14372 100644
--- a/drivers/net/ethernet/ibm/emac/mal.c
+++ b/drivers/net/ethernet/ibm/emac/mal.c
@@ -578,7 +578,7 @@ static int mal_probe(struct platform_device *ofdev)
 		printk(KERN_ERR "%pOF: Support for 405EZ not enabled!\n",
 				ofdev->dev.of_node);
 		err = -ENODEV;
-		goto fail;
+		goto fail_unmap;
 #endif
 	}