From: Filipe Manana Date: Thu, 1 Feb 2024 18:03:50 +0000 (+0000) Subject: btrfs: require no nodatacow for tests that exercise read repair X-Git-Tag: xfs-zoned-2024-06-07~144 X-Git-Url: https://www.infradead.org/git/?a=commitdiff_plain;h=07e9d3d39c3cb43dfebbd809bda4f91c17235e63;p=users%2Fhch%2Fxfstests-dev.git btrfs: require no nodatacow for tests that exercise read repair Several test cases that exercise the ability to detect corrupted data and repair it, fail when "-o nodatacow" is passed to MOUNT_OPTIONS, because that ability requires the existence of data checksums, and those are disabled in nodatacow mode. So skip the tests when "-o nodatacow" is present. Signed-off-by: Filipe Manana Reviewed-by: David Disseldorp Signed-off-by: Zorro Lang --- diff --git a/tests/btrfs/140 b/tests/btrfs/140 index 247a7356b..5ce658860 100755 --- a/tests/btrfs/140 +++ b/tests/btrfs/140 @@ -22,7 +22,8 @@ _begin_fstest auto quick read_repair fiemap # Modify as appropriate. _supported_fs btrfs _require_scratch_dev_pool 2 - +# No data checksums for NOCOW case, so can't detect corruption and repair data. +_require_btrfs_no_nodatacow _require_btrfs_command inspect-internal dump-tree _require_odirect # Overwriting data is forbidden on a zoned block device diff --git a/tests/btrfs/141 b/tests/btrfs/141 index 90a90d00d..e1adb91e4 100755 --- a/tests/btrfs/141 +++ b/tests/btrfs/141 @@ -22,6 +22,8 @@ _begin_fstest auto quick read_repair # Modify as appropriate. _supported_fs btrfs +# No data checksums for NOCOW case, so can't detect corruption and repair data. +_require_btrfs_no_nodatacow _require_scratch_dev_pool 2 _require_btrfs_command inspect-internal dump-tree diff --git a/tests/btrfs/157 b/tests/btrfs/157 index 022db5116..648db0d09 100755 --- a/tests/btrfs/157 +++ b/tests/btrfs/157 @@ -30,6 +30,8 @@ _begin_fstest auto quick raid read_repair # Modify as appropriate. _supported_fs btrfs +# No data checksums for NOCOW case, so can't detect corruption and repair data. +_require_btrfs_no_nodatacow _require_scratch_dev_pool 4 _require_btrfs_command inspect-internal dump-tree _require_btrfs_fs_feature raid56 diff --git a/tests/btrfs/158 b/tests/btrfs/158 index aa85835a0..28599d096 100755 --- a/tests/btrfs/158 +++ b/tests/btrfs/158 @@ -22,6 +22,8 @@ _begin_fstest auto quick raid scrub # Modify as appropriate. _supported_fs btrfs +# No data checksums for NOCOW case, so can't detect corruption and repair data. +_require_btrfs_no_nodatacow _require_scratch_dev_pool 4 _require_btrfs_command inspect-internal dump-tree _require_btrfs_fs_feature raid56 diff --git a/tests/btrfs/215 b/tests/btrfs/215 index 006468984..6fa226fe1 100755 --- a/tests/btrfs/215 +++ b/tests/btrfs/215 @@ -25,6 +25,8 @@ get_physical() # Modify as appropriate. _supported_fs btrfs _require_scratch +# No data checksums for NOCOW case, so can't detect corruption and repair data. +_require_btrfs_no_nodatacow # Overwriting data is forbidden on a zoned block device _require_non_zoned_device $SCRATCH_DEV diff --git a/tests/btrfs/265 b/tests/btrfs/265 index b75d9c849..127da7ada 100755 --- a/tests/btrfs/265 +++ b/tests/btrfs/265 @@ -19,6 +19,8 @@ _begin_fstest auto quick read_repair _supported_fs btrfs _require_scratch_dev_pool 3 +# No data checksums for NOCOW case, so can't detect corruption and repair data. +_require_btrfs_no_nodatacow _require_odirect # Overwriting data is forbidden on a zoned block device _require_non_zoned_device "${SCRATCH_DEV}" diff --git a/tests/btrfs/266 b/tests/btrfs/266 index 42aff7c09..acfb1d59d 100755 --- a/tests/btrfs/266 +++ b/tests/btrfs/266 @@ -18,6 +18,8 @@ _begin_fstest auto quick read_repair # real QA test starts here _supported_fs btrfs +# No data checksums for NOCOW case, so can't detect corruption and repair data. +_require_btrfs_no_nodatacow _require_scratch_dev_pool 3 _require_odirect diff --git a/tests/btrfs/267 b/tests/btrfs/267 index 75a6fdcc1..51b28d9bc 100755 --- a/tests/btrfs/267 +++ b/tests/btrfs/267 @@ -20,6 +20,8 @@ _begin_fstest auto quick read_repair _supported_fs btrfs _require_scratch_dev_pool 3 +# No data checksums for NOCOW case, so can't detect corruption and repair data. +_require_btrfs_no_nodatacow _require_odirect # Overwriting data is forbidden on a zoned block device _require_non_zoned_device "${SCRATCH_DEV}" diff --git a/tests/btrfs/268 b/tests/btrfs/268 index 9dc14a181..d122ee360 100755 --- a/tests/btrfs/268 +++ b/tests/btrfs/268 @@ -16,6 +16,8 @@ _begin_fstest auto quick read_repair _supported_fs btrfs _require_scratch _require_odirect +# No data checksums for NOCOW case, so can't detect corruption and repair data. +_require_btrfs_no_nodatacow _require_non_zoned_device "${SCRATCH_DEV}" # no overwrites on zoned devices _require_scratch_dev_pool 2 _scratch_dev_pool_get 2 diff --git a/tests/btrfs/269 b/tests/btrfs/269 index ad8f72867..7ffad1250 100755 --- a/tests/btrfs/269 +++ b/tests/btrfs/269 @@ -20,6 +20,8 @@ _begin_fstest auto quick read_repair _supported_fs btrfs _require_scratch _require_odirect +# No data checksums for NOCOW case, so can't detect corruption and repair data. +_require_btrfs_no_nodatacow _require_non_zoned_device "${SCRATCH_DEV}" # no overwrites on zoned devices _require_scratch_dev_pool 4 _scratch_dev_pool_get 4 diff --git a/tests/btrfs/289 b/tests/btrfs/289 index 39d8f733d..f1aaf4cc5 100755 --- a/tests/btrfs/289 +++ b/tests/btrfs/289 @@ -16,6 +16,8 @@ _begin_fstest auto quick scrub repair # Modify as appropriate. _supported_fs btrfs _require_scratch +# No data checksums for NOCOW case, so can't detect corruption and repair data. +_require_btrfs_no_nodatacow _require_odirect # Overwriting data is forbidden on a zoned block device